feat: update to black v24 and fix double curly braces (Updated PR #216) #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricoletc
changed the title
|
All looks good to me. Good idea on refactoring the As for merging from snakefmt branches, sure we can do that. I do prefer from my own fork though just in case I try and push to master, which wouldn't matter on my fork. There is an option to allow you to push to my PRs - it's a checkbox in the right panel of the PR below the "Lock conversation" section. If you select that it allows maintainers of snakefmt to push to the PR. Maybe we can just try and remember to check that. Anyway, I don't mind either way. |
mbhall88
approved these changes
Jan 31, 2024
|
Oh, being able to push to our respective forks is much better, as you say it protects us from mistakenly pushing to master here. Will have a look for that checkbox next time round (can't see it on the PR right now, though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I mistakenly closed #216, here's #216 + my two commits
@mbhall88 can you please respond to my comments on #216 and see if you're happy with my two added commits?
We can then keep updating this branch here.
Brice