Add e2e test for Purescript #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
Sep 2, 2024
There was a problem hiding this comment.
The structure looks good, I have some comments regarding handling errors.
Further, I think it would be nice if we refactor this code into reusable functions.
E.g., I am thinking of a function setupNlgEnv which has the type Interpreted -> IO NLGEnv, or something like that
fendor
approved these changes
Sep 4, 2024
Comment on lines
104
to
105
| must_sing_purs <- runIO $ transpileFile "must_sing" | ||
| it "convert must sing to Purescript" $ goldenGeneric "must_sing" must_sing_purs |
There was a problem hiding this comment.
Suggested change
| must_sing_purs <- runIO $ transpileFile "must_sing" | |
| it "convert must sing to Purescript" $ goldenGeneric "must_sing" must_sing_purs | |
| it "convert must sing to Purescript" $ do | |
| must_sing_purs <- transpileFile "must_sing" | |
| goldenGeneric "must_sing" must_sing_purs |
Then it is a perfect test case, imo!
Comment on lines
50
to
51
| putStrLn "natural4: encountered error while obtaining allNLGEnv" | ||
| DF.traverse_ putStrLn allNLGEnvErrors |
There was a problem hiding this comment.
Suggested change
| putStrLn "natural4: encountered error while obtaining allNLGEnv" | |
| DF.traverse_ putStrLn allNLGEnvErrors | |
| error $ unlines $ "natural4: encountered error while obtaining allNLGEnv" : allNLGEnvErrors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kosmikus , @fendor
As I mentioned I'm trying to set up minimal E2E testing for PS Transpiler before trying to refactor it.
As a first step I copied-and-pasted code from main just to run the transpiler without using any driver infra. Test code is very messy and can't even be used to write another test without complete copy and paste.
I was thinking maybe use driver infra but in this case should it be pulled out to other module where I can import it from?
Can you please provide your input on
I can set up a short call if it's faster to discuss over zoom.