Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract WebService into its own package #613

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Extract WebService into its own package #613

merged 11 commits into from
Sep 11, 2024

Conversation

fendor
Copy link
Contributor

@fendor fendor commented Aug 23, 2024

Move the REST API out of the explainable codebase into its own sub-package. This allows us to have a dedicated test-suite for the JSON schemas.

Additionally, it paves the way for a Simala backend which will be the alternative to the Explainable MathLang API.

@fendor fendor marked this pull request as draft August 23, 2024 13:23
@fendor fendor marked this pull request as ready for review August 28, 2024 09:30
@fendor fendor changed the title Draft: Extract WebService into its own package Extract WebService into its own package Aug 28, 2024
@fendor fendor requested review from mengwong and ym-han August 28, 2024 09:33
@fendor fendor force-pushed the feature/web-service branch 4 times, most recently from 1915bfa to b186c2a Compare September 9, 2024 08:56
Move the REST API out of the explainable codebase into its own
sub-package. This allows us to have a dedicated test-suite for the JSON
schemas.

Additionally, it paves the way for a Simala backend which will be the
alternative to the Explainable MathLang API.
The web-service is now decoupled from the backend implementation. Only
two locations are aware of the generic-mathlang:

* Configuration
* The GML backend which implements the evaluator
The Custom GPT doesn't understand this, yet, but it is still a net
improvement to before.
@fendor fendor merged commit 977c91c into main Sep 11, 2024
3 checks passed
@fendor fendor deleted the feature/web-service branch September 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant