-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract WebService into its own package #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
feature/web-service
branch
from
August 26, 2024 09:34
32dd4ba
to
55cd956
Compare
fendor
changed the title
Draft: Extract WebService into its own package
Extract WebService into its own package
Aug 28, 2024
fendor
force-pushed
the
feature/web-service
branch
4 times, most recently
from
September 9, 2024 08:56
1915bfa
to
b186c2a
Compare
Move the REST API out of the explainable codebase into its own sub-package. This allows us to have a dedicated test-suite for the JSON schemas. Additionally, it paves the way for a Simala backend which will be the alternative to the Explainable MathLang API.
The web-service is now decoupled from the backend implementation. Only two locations are aware of the generic-mathlang: * Configuration * The GML backend which implements the evaluator
fendor
force-pushed
the
feature/web-service
branch
from
September 9, 2024 10:18
b186c2a
to
485862b
Compare
fendor
force-pushed
the
feature/web-service
branch
from
September 9, 2024 13:43
f4374b6
to
706465d
Compare
The Custom GPT doesn't understand this, yet, but it is still a net improvement to before.
fendor
force-pushed
the
feature/web-service
branch
from
September 10, 2024 11:50
23bb2c6
to
0899492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the REST API out of the explainable codebase into its own sub-package. This allows us to have a dedicated test-suite for the JSON schemas.
Additionally, it paves the way for a Simala backend which will be the alternative to the Explainable MathLang API.