Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parsing of integer type for json, for number and int date on l4 #458

Merged
merged 2 commits into from
Oct 10, 2023
Merged

add parsing of integer type for json, for number and int date on l4 #458

merged 2 commits into from
Oct 10, 2023

Conversation

Meowyam
Copy link
Contributor

@Meowyam Meowyam commented Oct 10, 2023

add FTInteger to parse Int date to integer type in json, it was coming out as a ref

joewatt95
joewatt95 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@joewatt95 joewatt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, this looks good!

@joewatt95
Copy link
Contributor

I just made a change to transform FTNumber to Double instead of Int in showTypesHaskell, since FTInteger is being transformed to Int.

@joewatt95 joewatt95 merged commit afcab3b into main Oct 10, 2023
4 checks passed
@joewatt95 joewatt95 deleted the fix-integer-parsing branch October 10, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewatt95 joewatt95 joewatt95 approved these changes

@Martin-Strecker Martin-Strecker Awaiting requested review from Martin-Strecker

@ym-han ym-han Awaiting requested review from ym-han

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meowyam @joewatt95