Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the Docker image for arm64 as well #1548

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jan 3, 2024

@tomaka tomaka marked this pull request as draft January 3, 2024 13:53
@tomaka
Copy link
Contributor Author

tomaka commented Jan 3, 2024

Well, this can't work because we explicitly specify a --target in the Dockerfile.

@tomaka
Copy link
Contributor Author

tomaka commented Jan 3, 2024

Unfortunately, it takes an entire hour to build the ARM64 image, due to the build running in an emulator. As of recently, GitHub has added ARM64 runners, but they seem to be only for enterprises.

@tomaka
Copy link
Contributor Author

tomaka commented Jan 4, 2024

@tomaka
Copy link
Contributor Author

tomaka commented Jan 18, 2024

I believe that the code is now working, the only issue being that docker manifest create automatically pushes onto the registry and thus needs proper login.

The issue that the arm64 image takes an hour to build is unfortunately obviously problematic. Upgrading to a paid plan is not very costly by itself, but using the runner costs 0.16 € per minute, which is significant. An alternative could be to build the arm64 image only every now and then rather than at every PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant