Merge pull request #203 from MakarMS/master

fix(#202): Fix converting boolean when inserting into int and fix(#194): Fix unexpected readonly mode with specific string in query
smi2 · Jan 16, 2024 · 0d91abe · 0d91abe
2 parents bc7a0fd + cb7670b
commit 0d91abe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Quote/StrictQuoteLine.php b/src/Quote/StrictQuoteLine.php
@@ -113,6 +113,8 @@ function ($v) use ($enclosure_esc, $encode_esc) {
                 return (string) $value;
             }
 
+            $value = is_bool($value) ? ($value ? 'true' : 'false') : $value;
+
             if (is_string($value) && $encode) {
                 if ($tabEncode) {
                     return str_replace(["\t", "\n"], ['\\t', '\\n'], $value);

diff --git a/src/Transport/Http.php b/src/Transport/Http.php
@@ -301,12 +301,12 @@ private function makeRequest(Query $query, array $urlParams = [], bool $query_as
          */
 
         if ($query->isUseInUrlBindingsParams()) {
-            $urlParams=array_replace_recursive($query->getUrlBindingsParams());
+            $urlParams = array_replace_recursive($urlParams, $query->getUrlBindingsParams());
         }
+
         $url = $this->getUrl($urlParams);
         $new->url($url);
 
-
         if (!$query_as_string) {
             $new->parameters_json($sql);
         }