This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: Ignore Unimported Files Mentioned in .gitignore #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The implementation looks good to me. If you could add those tests you mentioned and a quick line in the readme, that'd be great. |
|
Tests and a mention in the README are both added now. |
|
Thanks! This is great FYI, this repo qualifies for hacktoberfest contributions if that's your thing. I've also added you as a collaborator on the project. Please feel free to continue to make PRs as you feel the need. You can now make your branches directly on the repo rather than your fork if you want. Thanks again! Much appreciated. ❤️ |
Closed
|
@all-contributors please add @Fritsch-Tech for code, test |
|
I've put up a pull request to add @Fritsch-Tech! 🎉 |
smeijer
pushed a commit
that referenced
this pull request
Oct 2, 2023
Adds @Fritsch-Tech as a contributor for code, test. This was requested by smeijer [in this comment](#184 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This pull request introduces the option to ignore unimported files listed in the
.gitignorefile, addressing the issue raised in #173. The handling of the.gitignoreis managed through ignore, as per your recommendation.This functionality can be enabled via the
respectGitignoresetting, which is set to true by default.Purpose
The addition of this feature enhances the tool's usability by allowing it to seamlessly work with projects where certain files are intentionally excluded via
.gitignore.To-Do
Before proceeding with the implementation of these tasks, I wanted to gather your feedback on the current changes. Your input is highly valuable.
Thank you for your time and consideration.