Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only run flakey tests on cron or dispatch #14871

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: only run flakey tests on cron or dispatch #14871

merged 1 commit into from
Oct 21, 2024

Conversation

erikburt
Copy link
Collaborator

@erikburt erikburt commented Oct 21, 2024 •
edited
Loading

Changes

  • Increases CI-Core scheduled frequency to every 6 hours, rather than every 24
  • Only run flakey tests detection on scheduled runs, and workflow dispatches

Motivation / Justification

  • Flakey tests detection is annoying for iterating and development.
  • The data is useful but should not interfere with regular validation
  • 1 data point per day is likely not enough to catch any meaningful levels of flakiness, so upping it to 4 times a day
  • Our scheduled runs cost about 8-10$ per run, so quadrupling the frequency of this scheduled run is a drop in the bucket in terms of added GHA costs

@erikburt erikburt self-assigned this Oct 21, 2024
@erikburt erikburt requested review from a team as code owners October 21, 2024 20:02
@erikburt erikburt added this pull request to the merge queue Oct 21, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit e037fa4 Oct 21, 2024
81 checks passed
@erikburt erikburt deleted the feat/flakey-tests-on-cron branch October 21, 2024 20:30
@erikburt erikburt mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momentmaker momentmaker momentmaker approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@chainchad chainchad chainchad approved these changes

Assignees

@erikburt erikburt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikburt @momentmaker @patrickhuie19 @chainchad