Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ramp overrides if explicit in nonce manager #14846

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow ramp overrides if explicit in nonce manager #14846

wants to merge 1 commit into from
+98 −40

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Oct 18, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@RensR RensR force-pushed the allow-nonce-manager-escape-hatch branch from 492e480 to 88b5f5f Compare October 18, 2024 13:47
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elatoskinas
elatoskinas approved these changes Oct 21, 2024
View reviewed changes
contracts/src/v0.8/ccip/test/NonceManager.t.sol
overrideExistingRamps: true
});

s_outboundNonceManager.applyPreviousRampsUpdates(previousRamps);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we assert event emits here?

contracts/src/v0.8/ccip/test/NonceManager.t.sol

s_outboundNonceManager.applyPreviousRampsUpdates(previousRamps);

previousRamps[0] = NonceManager.PreviousRampsArgs({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this line is not needed, since it's setting the same data as the previousRamps[0] above

contracts/src/v0.8/ccip/test/NonceManager.t.sol

s_outboundNonceManager.applyPreviousRampsUpdates(previousRamps);

previousRamps[0] =
NonceManager.PreviousRampsArgs(DEST_CHAIN_SELECTOR, NonceManager.PreviousRamps(prevOnRamp, address(0)));
previousRamps[0] = NonceManager.PreviousRampsArgs({
Copy link
Contributor

@elatoskinas elatoskinas Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line not needed, same data as the init above

contracts/src/v0.8/ccip/test/NonceManager.t.sol

s_outboundNonceManager.applyPreviousRampsUpdates(previousRamps);

previousRamps[0] =
NonceManager.PreviousRampsArgs(DEST_CHAIN_SELECTOR, NonceManager.PreviousRamps(address(0), prevOffRamp));
previousRamps[0] = NonceManager.PreviousRampsArgs({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line not needed, same data as above

contracts/src/v0.8/ccip/test/NonceManager.t.sol

s_outboundNonceManager.applyPreviousRampsUpdates(previousRamps);

previousRamps[0] =
NonceManager.PreviousRampsArgs(DEST_CHAIN_SELECTOR, NonceManager.PreviousRamps(prevOnRamp, prevOffRamp));
previousRamps[0] = NonceManager.PreviousRampsArgs({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line not needed, same data as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatoskinas elatoskinas elatoskinas approved these changes

@RayXpub RayXpub RayXpub approved these changes

@matYang matYang Awaiting requested review from matYang matYang is a code owner

@jhweintraub jhweintraub Awaiting requested review from jhweintraub jhweintraub is a code owner

@0xsuryansh 0xsuryansh Awaiting requested review from 0xsuryansh 0xsuryansh is a code owner

@RyanRHall RyanRHall Awaiting requested review from RyanRHall RyanRHall is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RensR @elatoskinas @RayXpub