Validation for required attributes #865
Conversation
| } | ||
| } | ||
| return m | ||
| } | ||
|
|
||
| func NewMetadata(attrs Attributes) *Metadata { | ||
| m := &Metadata{} | ||
| m := &Metadata{Timestamp: time.Now().UTC()} |
There was a problem hiding this comment.
@nanchano, We should try not to use attributes with unbounded cardinality.
It can cause various problems see this thread for details
https://chainlink-core.slack.com/archives/C06TEMFRPQD/p1729082258236499
There was a problem hiding this comment.
I could be wrong, but the unbounded cardinality issue is a problem for metrics, not for custom events, right?
There was a problem hiding this comment.
How would we wanna represent a timestamp then? As a string and let clients parse it?
| @@ -22,9 +23,9 @@ type Metadata struct { | |||
| // The version of the CL node. | |||
| NodeVersion string | |||
| // mTLS public key for the node operator. This is used as an identity key but with the added benefit of being able to provide signatures. | |||
| NodeCsaKey string | |||
| NodeCsaKey string `validate:"required"` | |||
There was a problem hiding this comment.
@4of9, are these going to be added as resource attributes to beholder config (since they are static) or we want to pass them as regular attributes?
There was a problem hiding this comment.
I was thinkin NodeCsaKey would be included as a resource attribute so users don't have to add it to every message
| "beholder_data_schema": "/schemas/ids/1001", // Required field, URI | ||
| "beholder_data_schema": "/schemas/ids/1001", // Required field, URI | ||
| "node_csa_key": "node_csa_val", // Required | ||
| "node_csa_signature": "mode_csa_signature_val", // Required |
There was a problem hiding this comment.
I don't think this would be an attribute, the signature will be coming through the authentication headers
Rules: