CCIP-3677 Observe different token data observers in parallel #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
requested review from
winder,
rstout,
asoliman92,
makramkd and
dimkouv
asoliman92
reviewed
Oct 7, 2024
| return nil, fmt.Errorf("merging token data together failed: %w", err) | ||
| } | ||
| case <-ctx.Done(): | ||
| // Return whatever was processed so far when context is canceled |
There was a problem hiding this comment.
To be sure. failed ones will be picked up in the next round?
There was a problem hiding this comment.
Yep, if message is ready to be executed, it should be included in the outcome and transmitted as an exec report to the chain. All failed ones would be retried in the next round if consensus is not reached
mateusz-sekara
changed the title
mateusz-sekara
force-pushed
the
paralell-token-data-observation
branch
from
dbe16f0
to
feeabce
Compare
|
winder
reviewed
Oct 8, 2024
| return tokenDataObservations, nil | ||
| } | ||
|
|
||
| resultsCh := make(chan exectypes.TokenDataObservations, len(c.observers)) |
There was a problem hiding this comment.
Some thoughts about the general approach.
- I'd like to see this be asynchronous to the Observe function. (i.e. persistent result channel + go routine collecting results).
- During Observe, send new/failed attestation requests out for observation and grab ones that are ready.
- Is there a timeout on the context?
- Channel size should be one or none: one or none.
winder
reviewed
Oct 8, 2024
| } | ||
|
|
||
| for i := 0; i < len(c.observers); i++ { | ||
| select { |
There was a problem hiding this comment.
The granularity of a result is an entire set of observations which causes problems when the context is done:
- The observers are notified to start returning accumulated attestations.
- The
ctx.Done()case is hit and immediately returns accumulated attestations (which doesn't include results from 1).
This means we're very likely to ignore all attestations when the timeout is hit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.