Allow passing patientId as url param #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-ignatov
requested changes
Aug 9, 2022
| iss = url.searchParams.get("iss") || iss; | ||
| fhirServiceUrl = url.searchParams.get("fhirServiceUrl") || fhirServiceUrl; | ||
| launch = url.searchParams.get("launch") || launch; | ||
| patientId = url.searchParams.get("patientId") || patientId; |
There was a problem hiding this comment.
patientId is a constant, so it can't be reassigned here. I think you only need to move its initialization from line 215 down to the let variables section (223 to 232). If you do that this PR should be ready for merging.
|
After #178 was merged in, this feature was incorporated into the codebase albeit in a slightly different way. Sorry for the delay on responding to this PR, but thank you for the input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.