Check for wrong line-endings when getting xref #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we didn't find the `xref` command at the offset specified, then replace Windows `\r\n` line endings with Unix style `\n` and try again. If it succeeds, then edit the line-endings and proceed as normal. Otherwise continue on to the `decodeXrefStream()` method. Fixes parsing of existing test suite file **/samples/bugs/Issue95_ANSI.pdf** the test for which would normally be passed over because of the `@group linux-only` flag. Remove this flag, as all assertions in the `testDecodeText()` function now resolve as true in any environment.
|
I would like to use Issue95_ANSI.pdf to create a few new assertions in |
k00ni
approved these changes
Aug 24, 2023
|
Yes, all good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we didn't find the
xrefcommand at the offset specified, then replace Windows\r\nline endings with Unix style\nand try again. If it succeeds, then edit the line-endings and proceed as normal. Otherwise continue on to thedecodeXrefStream()method.Fixes parsing of existing test suite file /samples/bugs/Issue95_ANSI.pdf the unit test for which would normally be passed over because of the
@group linux-onlyflag. Remove this flag, as all assertions in thetestDecodeText()function now resolve as true in any environment.