Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #621: Font::uchr: allow int|float for $code parameter #623

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

k00ni
Copy link
Collaborator

@k00ni k00ni commented Aug 1, 2023

Fixes #621

@k00ni k00ni added the fix label Aug 1, 2023
@k00ni k00ni self-assigned this Aug 1, 2023
@k00ni k00ni requested a review from j0k3r August 1, 2023 07:09
@k00ni k00ni marked this pull request as ready for review August 1, 2023 07:10
@k00ni
Copy link
Collaborator Author

k00ni commented Aug 1, 2023

@GreyWyvern Any remarks?

@k00ni k00ni changed the title Fixes #621: Font::uchr: use int|float for $code parameter Fixes #621: Font::uchr: allow int|float for $code parameter Aug 1, 2023
@k00ni k00ni merged commit c974994 into master Aug 3, 2023
26 checks passed
@k00ni k00ni deleted the fix/issue621 branch August 3, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font::uchr() method argument #1 expects int, but float given
2 participants