Add --password-file to crypto jwe encrypt
#1294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
needs triage
Matches the already existing flag for `crypto jwe decrypt`. While here fix usage string for the existing flag since it deals with decryption.
eest
force-pushed
the
crypto_jwe_encrypt_password
branch
from
f355224
to
e781ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Add
--password-filetocrypto jwe encryptPain or issue this feature alleviates:
Makes it possible to run the command without prompts for input if e.g. running it from a script to modify the password of a user as described in https://smallstep.com/docs/step-ca/provisioners/#changing-a-jwk-provisioner-password. The flag also matches the already available flag for the
decryptcommand. Also the usage string for thedecryptcommand has been updated to mention decryption. This fix basically mirrors how things are done in decrypt.go.Why is this important to the project (if not answered above):
Helpful for scripting with the step client.
Is there documentation on how to use this feature? If so, where?
The flag includes a usage string.
In what environments or workflows is this feature supported?
Any using step cli.
In what environments or workflows is this feature explicitly NOT supported (if any)?
N/A
Supporting links/other PRs/issues:
💔Thank you!