(3/3) Extract player as Web Components #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 13, 2022 10:35
- Remove methods in DlfMediaPlayer that just forward to seek bar. - Prepare moving seek bar to a new frontend class.
This prepares various changes: - Make modal parent configurable, so modals may not be created if the given parent is invalid. - Later, extract custom element where modals are created in `connectedCallback()`.
This fixes the issue that when using the fullscreen button on the player instead of a keybinding to enter fullscreen, the modals couldn't be opened. Here we extract our own fullscreen button, and use the correct container as fullscreenElement for both keybinding and button. Also, move `toggleFullScreen` to `Environment`.
- `afterManualSeek()` - `handleEscape()` - Gesture initialization
- Move to `ShakaFrontend` - Merge fps/chapter/variantGroups events - Use for poster
There's more that could be done here, but it's also a preparation for converting the player to custom elements.
The idea has been that the player could also be unmounted. This will be superseded by Custom Elements.
Don't rely on event listeners being registered after load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #25. The player is refactorized as Web Component, so that it can be embedded via the custom HTML tags
<dlf-media>and<slub-media>.