-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move package files to top level #26
base: main
Are you sure you want to change the base?
refactor: move package files to top level #26
Conversation
This PR includes: - Moving `package.json`, `package-lock.json`, `.eslintrc.json`, and `task.json` to the root of the repository - Renaming `buildAndReleaseTask` to `src` - Adding the `build` task as an npm script - Adding `build` to the GitHub Action - Outputting the compiled JavaScript to the `dist` folder, instead of alongside the TypeScript source Signed-off-by: Jamie Magee <[email protected]>
@gattjoe this is ready for review |
@JamieMagee I'm going to have to stare at this a bit to determine the implications. I've only ever set it up according to the documentation; however, the documentation doesn't say whether or not what you suggest is not possible, its fairly ambiguous. I'll take a look this week at it. |
I understand where you are coming from, but the layout suggested in your link is specifically for the tutorial:
The important parts are the azure-devops-demo/vss-extension.json Lines 23 to 30 in c1d53b8
and azure-devops-demo/buildAndReleaseTask/task.json Lines 34 to 39 in c1d53b8
The directory structure and hierarchy is pretty free-form, but the standard that defines it is called Open Packaging Conventions1. There's some more documentation on it here. Footnotes |
Signed-off-by: Jamie Magee <[email protected]>
I updated the target paths for |
@JamieMagee thanks for the link to the vsix package documentation, reading now. |
hmm this is failing tests. I think I have to change a few things in index.ts since it relies on task.json. They used to be in the same directory, so it wasn't an issue before. I have to think about what the execution environment is going to look like from an agent perspective. Overall, the biggest problem I have is that I have to literally publish a "BETA" version of the extension privately to KNOW if it will work in the wild. I have a different version of the agent published privately, and I'm happy to set up a pipeline in my ADO organization against a fork so you can iterate with it. If you have your own ADO organization, I can share the extension with you to install. |
This PR includes:
package.json
,package-lock.json
,.eslintrc.json
, andtask.json
to the root of the repositorybuildAndReleaseTask
tosrc
build
task as an npm scriptbuild
to the GitHub Actiondist
folder, instead of alongside the TypeScript sourceSigned-off-by: Jamie Magee [email protected]