Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to omit region name in endregion tag in code snippets #1908

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Oct 25, 2024

fix #1828.

Previously, regionname was required in // #endregion regionname. This PR supports omitting the regionname, just like VSCode.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit dee71bd
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/671b49fedd16d9000887be49
😎 Deploy Preview https://deploy-preview-1908--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1908

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1908

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1908

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1908

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1908

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1908

commit: dee71bd

@antfu antfu merged commit d5aa687 into slidevjs:main Oct 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region Folding requires start and end tags to have region name but vscode/jetbrains does not
2 participants