Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display slide import errors in client #1816

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: display slide import errors in client #1816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e247019
Make slide import errors appear in the console
AlbertBrand Aug 13, 2024
825e71d
Update error message
AlbertBrand Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/slidev/node/virtual/slides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const templateSlides: VirtualModuleTemplate = {
// For some unknown reason, import error won't be caught by the error component. Catch it here.
`const load${no} = async () => {`,
` try { return componentsCache[${idx}] ??= await import('${VIRTUAL_SLIDE_PREFIX}${no}/md') }`,
` catch (e) { return SlideError }`,
` catch (e) { console.error('slide failed to load', e); return SlideError }`,
`}`,
)
return `{ no: ${no}, meta: f${no}, load: load${no}, component: getAsyncComponent(${idx}, load${no}) }`
Expand Down
Loading