Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn and ignore custom index.html with doctype declaration #1793

Merged
merged 6 commits into from
Aug 11, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Aug 2, 2024

Index.html may not be deleted because of a user-terminated previous build. This PR ignores index.html in the user root with <DOCTYPE html>.

This PR also stores the result of getIndexHtml into options.utils

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 1d9569d
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66b86bee2e8ce70008c70c41
😎 Deploy Preview https://deploy-preview-1793--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KermanX KermanX marked this pull request as draft August 2, 2024 04:51
@KermanX KermanX marked this pull request as ready for review August 2, 2024 05:06
@KermanX KermanX merged commit d72f0a0 into slidevjs:main Aug 11, 2024
18 checks passed
@KermanX KermanX changed the title feat: warn and ignore provided index.html with doctype declaration feat: warn and ignore custom index.html with doctype declaration Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant