fix: code snippets HMR #1789
Merged
fix: code snippets HMR #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
approved these changes
Jul 28, 2024
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix HMR for code snippets (
<<< path/to/snippet.ts)Redesigned
data.watchFiles:Previously, it was an array for all watched files that should trigger Slidev's
handleHotUpdate. InhandleHotUpdate, Slidev first loads the slides and compares each slide to know which slide should be updated. However, code snippets are loaded in transform hook. The newdata.watchFilesis an object mapping from the watched file path to slide indexes that must be updated when the file is changed.