Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not pass entry files to MarkdownIt #1773

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Jul 22, 2024

fix #1772.

This is a regression caused by #1767. In which the check of whether the processed file is the entry file was removed from the before hook of unplugin-vue-markdown.

And inside handleHotUpdate, await ctx.read was called because of #884. Unfortunately, unplugin-vue-markdown overrides this method here. This causes unexpected processing of the entry file, while the client hasn't import it at all.

This PR fixes this by adding order: 'pre' to the loader plugin to use await ctx.read before unplugin-vue-markdown, and re-adding the checks in the before hook of unplugin-vue-markdown.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 65e08f2
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/669e1e6a2e2967000805deb0
😎 Deploy Preview https://deploy-preview-1773--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid props when editing initial slides.md file
2 participants