Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): hover message, formatting and highlighting #1771

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Jul 21, 2024

Fixes:

  • "Scheme not found" error on my machine
  • Hover message wasn't rendered as Markdown
  • Prettier used to parse frontmatters as Markdown instead of YAML
  • Highlight all inside code block attributes
  • Add trailing comma new line to generated schemas so that ESLint won't complain (should the generated files be added to .gitignore?)

Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 45380a6
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/669c93e6d477b40008251d5d
😎 Deploy Preview https://deploy-preview-1771--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Jul 21, 2024

Add trailing comma to generated schemas so that ESLint won't complain (should the generated files be added to .gitignore?)

I am up to it.

Feel free to merge and do a release.

@KermanX
Copy link
Member Author

KermanX commented Jul 21, 2024

Sorry I meant "trailing new line"🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants