Adding C/C++ linter to CI #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an else has a brace on one side, it should have it on both [readability/braces]
Almost always, snprintf is better than strcpy [runtime/printf]
Found C system header after other header. Should be: axis_gen1.h, c system, c++ system, other. [build/include_order]
linux/types.h already included at XXXX [build/include]
[runtime/casting] is acceptable risk for this aximemorymap driver
Add #include <XXX> for YYY [build/include_what_you_use]
Empty loop bodies should use {} or continue [whitespace/empty_loop_body]
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line]
{ should almost always be at the end of the previous line [whitespace/braces]
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line]
Missing spaces around XXX [whitespace/operators]
Extra space after ( in XXXX call [whitespace/parens]
At least two spaces is best between code and comments [whitespace/comments]
Missing space after , [whitespace/comma]
Merged
Else clause should never be on same line as else (use 2 lines) [whitespace/newline]
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces]
|
Hi Larry,
I probably won't get to review this before Wednesday or Thursday next week.
Cheers,
Jeremy
…On Sat, Jul 6, 2024, 11:43 AM Larry Ruckman ***@***.***> wrote:
@ruck314 <https://github.com/ruck314> requested your review on: #148
<#148> Adding C/C++
linter to CI.
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEWNXQHPHYIFPO44KQKZZLTZLA3FXAVCNFSM6AAAAABKN7UCBCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGQYTEMBUGMYTMMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
DMA Loopback using aes-stream-driver@ 4e1533d looks good |
JJL772
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description