Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More sanity checks for comp_and_load_drivers.sh #140

Merged
merged 1 commit into from
May 31, 2024
Merged

More sanity checks for comp_and_load_drivers.sh #140

merged 1 commit into from
May 31, 2024

Conversation

JJL772
Copy link
Member

@JJL772 JJL772 commented May 30, 2024

Description

Added more sanity checks to comp_and_load_drivers.sh

Details

  • Ensure the compiler version we're building the NVIDIA drivers and datagpu with match what the kernel was built with.
  • Don't enforce gcc-12, only enforce what the kernel was built with
  • Only load the ecc module if it exists. On older kernels (i.e. RHEL7's 3.10.X), ecc doesn't exist and isn't needed by the nvidia driver.

The script is a bit sloppy because I'm not great with bash :)

@JJL772 JJL772 requested a review from ruck314 May 31, 2024 00:22
@ruck314 ruck314 merged commit d70defc into pre-release May 31, 2024
2 checks passed
@ruck314 ruck314 mentioned this pull request May 31, 2024
Merged
@ruck314 ruck314 deleted the more-sanity-checks branch May 31, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruck314 ruck314 ruck314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJL772 @ruck314