Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert: Remove unnecessary ux_utils.print_exception_no_traceback() wrappers #4130

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Partially revert: Remove unnecessary ux_utils.print_exception_no_traceback() wrappers #4130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions sky/serve/serve_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,12 +566,10 @@ def load_service_initialization_result(payload: str) -> int:
def check_service_status_healthy(service_name: str) -> Optional[str]:
service_record = serve_state.get_service_from_name(service_name)
if service_record is None:
with ux_utils.print_exception_no_traceback():
return f'Service {service_name!r} does not exist.'
return f'Service {service_name!r} does not exist.'
if service_record['status'] == serve_state.ServiceStatus.CONTROLLER_INIT:
with ux_utils.print_exception_no_traceback():
return (f'Service {service_name!r} is still initializing its '
'controller. Please try again later.')
return (f'Service {service_name!r} is still initializing its '
'controller. Please try again later.')
return None


Expand Down Expand Up @@ -674,9 +672,8 @@ def stream_replica_logs(service_name: str, replica_id: int,
launch_log_file_name = generate_replica_launch_log_file_name(
service_name, replica_id)
if not os.path.exists(launch_log_file_name):
with ux_utils.print_exception_no_traceback():
return (f'{colorama.Fore.RED}Replica {replica_id} doesn\'t exist.'
f'{colorama.Style.RESET_ALL}')
return (f'{colorama.Fore.RED}Replica {replica_id} doesn\'t exist.'
f'{colorama.Style.RESET_ALL}')

replica_cluster_name = generate_replica_cluster_name(
service_name, replica_id)
Expand Down
Loading