[OCI] Re-Implementation with the new provision API framework. #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HysunHe
force-pushed
the
new_provision_api
branch
from
8f9b57e
to
3c3bcee
Compare
|
Resolved conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to implement the OCI support in SkyPilot under its new provision API framework. The old implementation is deleted.
Leveraging the SkyPilot new provision API framework, this PR is expected to solve the TIMEOUT issue in the "old" implementation for some OCI VMs which needs long time to complete the setup/init.
It also includes some minor enhancement/fix.
This PR should be review/merged after #4080
All functions in the "old" implemented are now tested against with the new implementation.
All tests are passed.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh