Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automated weekly smoke tests with GitHub Actions #4113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andylizf
Copy link
Contributor

Fixes #4112

Implement an automated weekly smoke test run using GitHub Actions leveraging the existing tests/test_smoke.py script.

  • Add a new GitHub Actions workflow file .github/workflows/weekly-smoke-tests.yml.
  • Schedule the workflow to run weekly using cron syntax.
  • Set up the environment and install dependencies.
  • Run pytest tests/test_smoke.py --terminate-on-failure.
  • Handle different test groups (AWS, GCP, Azure, Lambda, Kubernetes) as defined in the script.
  • Add necessary cloud credentials as GitHub secrets.
  • Upload test results as artifacts.

@Michaelvll
Copy link
Collaborator

Michaelvll commented Oct 17, 2024

Thanks for adding this @andylizf! There are several things to investigate for this, including, how we reduce the cost of the smoke test, how to reduce the flakiness of the smoke test, whether we should use a subset of the smoke tests instead of the entire tests for efficiency and cost, and whether we should use a third-party tool, buildkite, than using Github action, as seems many OSS projects are using that.

https://github.com/ray-project/ray/tree/master/.buildkite
https://github.com/vllm-project/vllm/tree/main/.buildkite
https://buildkite.com/

@Michaelvll
Copy link
Collaborator

Also, I just canceled all the smoke test actions, as that can take a long time and we don't have the credentials setup (should we?). I guess a better way to do this is to list the alternatives and routes we will go with in a design doc before submitting the PR. : )

@andylizf
Copy link
Contributor Author

Yep, I’ve already flagged those tricky issues in the related GitHub issue, including cost-cutting and reducing flakiness in the smoke tests. I’m going to try running it on GitHub Actions using my own GCP credentials first to see how that works out

@Michaelvll
Copy link
Collaborator

Sounds good! Please be careful with the leaked resources in cloud and cost for running in CI. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Automated Weekly Smoke Tests
2 participants