Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raises error when user tries to update an existing service to Rolling… #4085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raises error when user tries to update an existing service to Rolling… #4085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sky/serve/serve_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,4 +963,7 @@ def update_service(cls, service_name: str, version: int, mode: str) -> str:
f'{version}, **mode_kwargs)',
'print(msg, end="", flush=True)',
]
if mode == UpdateMode.ROLLING:
raise exceptions.NotSupportedError(
f'Rolling updates not supported on {service_name} service')
return cls._build(code)
Loading