Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force option to sky down #4060

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andylizf
Copy link
Contributor

@andylizf andylizf commented Oct 10, 2024

Resolve #4059

Add a --force option to the sky down command to handle services stuck in the SHUTTING_DOWN state.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cblmemo cblmemo self-requested a review October 10, 2024 16:39
@cblmemo
Copy link
Collaborator

cblmemo commented Oct 10, 2024

I'm a little confused. #4059 says we need a --force for sky serve down but this is adding -f to sky down. Is it expected?

@andylizf
Copy link
Contributor Author

I'm a little confused. #4059 says we need a --force for sky serve down but this is adding -f to sky down. Is it expected?

It's a typo in the original issue, but you make me realize that the semantic is indeed not clear enough so I think maybe an option named ignore-if-controller would be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add a force option to sky down to handle services controller stuck in SHUTTING_DOWN state
2 participants