Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Refactor is_same_cloud #3568

Merged
merged 3 commits into from
May 20, 2024
Merged

[Minor] Refactor is_same_cloud #3568

merged 3 commits into from
May 20, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 20, 2024 •
edited
Loading

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test echo hi
    • sky launch -c test --cloud gcp --cpus 2 echo hi
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo May 20, 2024 19:14
romilbhardwaj
romilbhardwaj approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! LGTM after removing from azure.py.

sky/clouds/aws.py Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 6a624b2 into master May 20, 2024
20 checks passed
@Michaelvll Michaelvll deleted the minor-refactor branch May 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

@cblmemo cblmemo Awaiting requested review from cblmemo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michaelvll @romilbhardwaj