Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Allow cancel autostop for cluster on k8s #3525

Merged
merged 3 commits into from
May 8, 2024
Merged

[k8s] Allow cancel autostop for cluster on k8s #3525

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52e8aba
Allow autodown for k8s
Michaelvll May 8, 2024
e5f7e0b
k8s allow cancel
Michaelvll May 8, 2024
8a118f4
Merge branch 'master' of github.com:skypilot-org/skypilot into allow-…
Michaelvll May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sky/backends/cloud_vm_ray_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4066,7 +4066,7 @@ def set_autostop(self,
if idle_minutes_to_autostop is not None:
# Skip auto-stop for Kubernetes clusters.
if (isinstance(handle.launched_resources.cloud, clouds.Kubernetes)
and not down):
and not down and idle_minutes_to_autostop >= 0):
# We should hit this code path only for the jobs controller on
# Kubernetes clusters.
assert (controller_utils.Controllers.from_name(
Expand Down
Loading