Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Avoid rsync for setup #3523

Merged
merged 2 commits into from
May 10, 2024
Merged

[Core] Avoid rsync for setup #3523

merged 2 commits into from
May 10, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 8, 2024 •
edited
Loading

This is to reduce the overhead for rsync'ing setup to the remote VM. Similar optimization as #3394

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test test.yaml
    • sky launch --detach-setup -c test test.yaml
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

concretevitamin
concretevitamin reviewed May 8, 2024
View reviewed changes
sky/backends/cloud_vm_ray_backend.py Outdated Show resolved Hide resolved
sky/backends/cloud_vm_ray_backend.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 457bccb into master May 10, 2024
20 checks passed
@Michaelvll Michaelvll deleted the avoid-rsync-for-setup branch May 10, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michaelvll @concretevitamin