[k8s] Disable autostop for controller on kubernetes

[romilbhardwaj]

Skips autostop when using the jobs controller on Kubernetes.

This should be merged after #3377, since that PR will add support for SERVICE_ACCOUNT, which is helpful for running the controller on GKE exec based auth clusters.

Tested (run the relevant ones):

• Code formatting: bash format.sh
• Tested manually with sky jobs launch with controller and job on Kubernetes
• Managed job smoke tests pytest tests/test_smoke.py --managed-jobs --kubernetes

[Michaelvll]

Thanks @romilbhardwaj! LGTM.

[romilbhardwaj]

Thanks @Michaelvll! Tested with pytest tests/test_smoke.py --managed-jobs --kubernetes on GKE cluster with this config.yaml:

kubernetes:
  remote_identity: SERVICE_ACCOUNT
jobs:
  controller:
    resources:
      cloud: kubernetes
      cpus: 8
      memory: 8

[Michaelvll]

Thanks @Michaelvll! Tested with pytest tests/test_smoke.py --managed-jobs --kubernetes on GKE cluster with this config.yaml:

kubernetes:
  remote_identity: SERVICE_ACCOUNT
jobs:
  controller:
    resources:
      cloud: kubernetes
      cpus: 8
      memory: 8

Awesome! Can we also test it without explicit specify the controller resources?

[romilbhardwaj]

Yes, smoke tests pass even without specifying controller resources! Kubernetes is automatically chosen for the controller if it has enough resources (8 CPU, 24 GB mem), verified with kubectl get pods.

[Michaelvll]

nit: would be nice to add ()

Suggested change

	if isinstance(to_provision.cloud, clouds.Kubernetes
	) and controller_utils.Controllers.from_name(
	cluster_name
	) == controller_utils.Controllers.JOBS_CONTROLLER:
	if (isinstance(to_provision.cloud, clouds.Kubernetes
	) and controller_utils.Controllers.from_name(
	cluster_name
	) == controller_utils.Controllers.JOBS_CONTROLLER):