Skip to content

Commit

Permalink
[SkyServe] Check positive for target_qps_per_replica (#2995)
Browse files Browse the repository at this point in the history
fix
  • Loading branch information
cblmemo authored Jan 18, 2024
1 parent b59ab22 commit f0bb6ba
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions sky/serve/service_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ def __init__(
raise ValueError(
'max_replicas must be greater than or equal to min_replicas'
)
if target_qps_per_replica is not None and target_qps_per_replica <= 0:
with ux_utils.print_exception_no_traceback():
raise ValueError(
'target_qps_per_replica must be greater than 0')
if not readiness_path.startswith('/'):
with ux_utils.print_exception_no_traceback():
raise ValueError('readiness_path must start with a slash (/). '
Expand Down

0 comments on commit f0bb6ba

Please sign in to comment.