Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] ruff linting - allow use of assert (S101) #1701

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[MNT] ruff linting - allow use of assert (S101) #1701

merged 1 commit into from
Oct 22, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 22, 2024

Currently, pre-commit trips over uses of assert which exist in non-test code across the code base.

This is often discouraged, but a de-facto part of the current code base, so for now we should simply skip the corresponding linting rule.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Oct 22, 2024
@fkiraly fkiraly merged commit b8c3980 into main Oct 22, 2024
3 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant