[MNT] fix black doesn't have extras dependency
#1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
approved these changes
Oct 18, 2024
fkiraly
added
the
maintenance
If we are using ruff we can remove black or depending on @yarnabrina suggestion on linters we might need to add extra linters given that ruff doesn't have some rules implemented. |
|
I was quite a strong supporter of ruff, but given the limitation of multi file analysis, I'm now quite concerned in general. But it's for the linting component so far, I do not have any opinion for the formatting component. |
fkiraly
changed the title
black doesn't have extras dependencyblack doesn't have extras dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the correct dependency for
blackjupyter instead ofextrasas it doesn't have that.