161 search by notation #269
Conversation
Need to change to Document indexing instead of "normal" Index. Then add all the respective labels there. PoC was kind of successfull, now needs to be polished.
now attributes that are arrays, languageMapArrays or languageMaps are supported
the action keeps failing, but works locally totally fine. Maybe adding an explicit browser helps
|
The failing tests, I might handle in a separate issue. Everything goes through locally and I suspect some GitHub Action related issue, since sometimes one cypress test fails and sometimes two. |
adding a wait after the click like recommended here https://stackoverflow.com/a/76435762
|
ok, I'm giving up with the cypress GitHub Action thing. Local tests work. I will disable this action for now and open an issue for it. |
conceptSchemeId was sometimes still having the old value. This led to unneccessary double rendering. Removal seems to improve performance and reduce errors with fetching the wrong index (cause the old conceptSchemeId was still hanging around).
I improved testing and also the components. Maybe there was something I overlooked before. Still don't know why it works locally, but fails in the action. Let's see if this is still the case.
This reverts commit bc7c662.
|
@acka47 you can test now, e.g. https://test.skohub.io/sroertgen/test-vocabs/heads/main/w3id.org/two-concepts-one-file/c1.de.html or you can send your own vocab to the test-server |
|
Telephone protocol: |
|
@acka47 please check again. |
|
This looks really good. One last UX thing: I find myself adjusting toggle buttons and then trying to click into the search window to start a search. This won't work at the moment and I have to go back to hit the "close" button first. There are two options for improvements:
|
|
@acka47 Outside closing is now implemented. |
The labels from
skos:altLabelskos:notationskos:hiddenLabelskos:definitionare now indexed. By selection of the respective label, only the relevant index gets loaded. This means we don't have one blown up index, but multiple for each label, which makes us handle even quite large vocabs performant.
Also flexsearch has quite improved, so the index is not so big like before.
Re: Accessibility you are now able to check and uncheck boxes using
Alt + <first letter of labele.g.Alt + ato toggle search for altLabels.Ctrl + kwill you bring back to the search box.Would like to know if the remaining labels i asked for in #128 should also be added. Since they will not blow up the index by default, I see no problem in doing so.
Will close #128 #161