Skip to content

Commit

Permalink
reenabling e2e test. See if it works now
Browse files Browse the repository at this point in the history
I improved testing and also the components. Maybe there was something I overlooked before.
Still don't know why it works locally, but fails in the action.
Let's see if this is still the case.
  • Loading branch information
sroertgen committed Sep 1, 2023
1 parent 6bc9c72 commit bc7c662
Showing 1 changed file with 23 additions and 23 deletions.
46 changes: 23 additions & 23 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,29 +48,29 @@ jobs:
- run: npm run test

# disables because the action fails on github action but tests works locally
# e2e:
# runs-on: ubuntu-latest
# strategy:
# matrix:
# node-version: [18.x]
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# - name: Use Node.js ${{ matrix.node-version }}
# uses: actions/setup-node@v3
# with:
# node-version: ${{ matrix.node-version }}
# - run: echo Using node version $(node --version)
# - run: echo Using npm version $(npm --version)
# - run: cypress/prepare-cypress-test.sh
# - name: Cypress run
# uses: cypress-io/github-action@v5
# with:
# browser: chrome
# headed: true
# start: npm run develop -- -p 8000
# wait-on: http://localhost:8000/index.de.html
# config: baseUrl=http://localhost:8000
e2e:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: echo Using node version $(node --version)
- run: echo Using npm version $(npm --version)
- run: cypress/prepare-cypress-test.sh
- name: Cypress run
uses: cypress-io/github-action@v5
with:
browser: chrome
headed: true
start: npm run develop -- -p 8000
wait-on: http://localhost:8000/index.de.html
config: baseUrl=http://localhost:8000

docker:
needs: [build]
Expand Down

0 comments on commit bc7c662

Please sign in to comment.