Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRE-1161] remove debounce to simplify code and clear inputs on route complete or reload #402

Closed
wants to merge 6 commits into from
Closed

[FRE-1161] remove debounce to simplify code and clear inputs on route complete or reload #402

wants to merge 6 commits into from

Conversation

ericHgorski
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1dadd45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 5:03pm

toddkao
toddkao requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@toddkao toddkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand by the fact that we shouldn't get rid of the debouncing, I'm fine with re-implementing in another way but not removing it

@ericHgorski
Copy link
Contributor Author

I stand by the fact that we shouldn't get rid of the debouncing, I'm fine with re-implementing in another way but not removing it

Just want to get this up as an option as it does fix the original issue. Tried 4-5 debouncing alternatives and non were satisfactory. You can add theuseLayoutEffect with the original debounced code and is basically works except for some weird visual loading behavior.

ericHgorski
ericHgorski commented Nov 1, 2024
View reviewed changes
packages/widget-v2/src/widget/Widget.tsx
@@ -89,16 +93,28 @@ const WidgetWithoutNiceModalProvider = (props: WidgetProps) => {
setTheme(mergedTheme);
}, [setSkipClientConfig, mergedSkipClientConfig, setTheme, mergedTheme]);

useLayoutEffect(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toddkao

@ericHgorski ericHgorski closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddkao toddkao toddkao requested changes

@codingki codingki Awaiting requested review from codingki codingki is a code owner

@NotJeremyLiu NotJeremyLiu Awaiting requested review from NotJeremyLiu NotJeremyLiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericHgorski @toddkao