Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tokenAndChainSelectorModal as assetAndChainSelectorModal #388

Merged
merged 20 commits into from
Oct 29, 2024
Merged

Rename tokenAndChainSelectorModal as assetAndChainSelectorModal #388

merged 20 commits into from
Oct 29, 2024

Conversation

toddkao
Copy link
Collaborator

@toddkao toddkao commented Oct 28, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 87a1db5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs 🛑 Canceled (Inspect) Oct 29, 2024 5:51pm

@toddkao toddkao changed the title rename tokenAndChainSelectorModal as assetAndChainSelectorModal Rename tokenAndChainSelectorModal as assetAndChainSelectorModal Oct 28, 2024
@toddkao toddkao marked this pull request as ready for review October 28, 2024 22:16
@toddkao toddkao mentioned this pull request Oct 28, 2024
Merged
ericHgorski
ericHgorski approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ericHgorski ericHgorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from add-more-props to main October 29, 2024 17:38
@toddkao toddkao merged commit b83912a into main Oct 29, 2024
5 of 6 checks passed
@toddkao toddkao deleted the rename-token-and-chain-selector-modal branch October 29, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericHgorski ericHgorski ericHgorski approved these changes

@codingki codingki Awaiting requested review from codingki codingki is a code owner

@NotJeremyLiu NotJeremyLiu Awaiting requested review from NotJeremyLiu NotJeremyLiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddkao @ericHgorski