Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart Swap documentation improvements #258

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Smart Swap documentation improvements #258

merged 7 commits into from
Sep 23, 2024

Conversation

ericHgorski
Copy link
Contributor

@ericHgorski ericHgorski commented Sep 18, 2024 •
edited
Loading

Improved copy, organization, and code examples

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 6:52pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6096c69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericHgorski ericHgorski changed the title Refactor Smart Swap documentation Smart Swap documentation improvements Sep 20, 2024
NotJeremyLiu
NotJeremyLiu approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@NotJeremyLiu NotJeremyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some wording comments/nits, approving now, feel free to merge once feedback is addressed / ping me to re-review if you'd like

@ericHgorski ericHgorski merged commit 2ee07e0 into main Sep 23, 2024
4 of 5 checks passed
@ericHgorski ericHgorski deleted the chore/upd-smart-swap-docs branch September 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotJeremyLiu NotJeremyLiu NotJeremyLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericHgorski @NotJeremyLiu