Fixed roDeviceInfo method type and some test cases
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor in preparation for adoption the project
…ot-compliant Fixed `val()` edge cases: hex without radix and `NaN`
* add logic for optional chaining * remove console log * format doc * fix test * fix uts
* Preventing multiple calls for dot-chained methods * Fixed `prettier` issue
…nd `roAssociativeArray` (#33) * Implements missing methods from `ifEnum` in `roArray` and `roAssociativeArray` #26 * Implemented unit tests * Prettier fix --------- Co-authored-by: Bronley Plumb <[email protected]>
* feat(lex): Emit try/catch/throw lexemes for parsing RBI 9.4 adds support for error handling via the `try`/`catch` model [1]. Interestingly, `try`, `catch`, and `endtry` are all valid identifiers! That makes parsing a little bit tougher, but it's not unprecedented in this language. Detect `try`/`catch`/throw`/`end try` during lexing and emit the proper lexemes. [1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html see sjbarag#554 * feat(parse): Consume try, catch, and end try lexemes Throwing exceptions and catching them aren't yet supported in `brs`, so executing only the `try` block seems to be a reasonable "bare minimum" approach to try/catch support. Handle `try`, `catch`, and `end try` lexemes in the parser, emitting TryCatch statements for the interpreter to execute naïvely. see sjbarag#554 * Fixed Test Case --------- Co-authored-by: Sean Barag <[email protected]> Co-authored-by: Bronley Plumb <[email protected]>
* Adds create-package CI build for quicker iteration * fix illegal URL chars in name * use - instead of _ * better release title
* fix(lib): Component XML path parsing was failing on edge case * Fixed search string to match what `fast-glob` supports
Co-authored-by: Bronley Plumb <[email protected]>
…()` are not properly boxing parameters (#42)
…th()` (#44) * Fixed # 43 - Implemented `roString` methods `startsWith()` and `endsWith()` * Fixed test code formatting
* Added support for bitwise NOT * Prettier Fixes
* Added option to disable colors and fixed unit tests to not fail with colors * Implemented `roPath` and fixed comparison to match Roku behavior * Added unit tests and fixed prettier issues * Properly compare Number with Boolean * Added support to AND and OR between Boolean and Numbers * Updated unit tests and fixed Int64 * Improved URL regex for CLI colorizer
* Implemented `roByteArray` component * Added unit tests and fixed issues on roByteArray * Fixes to `roArray` and `roList` * Removed empty line from a test file
* Implemented `Box()` function and improved boxing on Numbers and Boolean * Fixed lint issue * Fixed Invalid check when on the left side does not work (boxing issue) #7 * Moved `debugLocalVariables()` to interpreter (to be used by MicroDebugger in the future) * Fixed `-n, --no-color` CLI option * Documented `debugLocalVariables()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
getAudioDecodeInfowas wrongly spelled, andgetSupportedGraphicsResolutionswas returning an AA when the correct is aroArray.Skipped one
roXMLElementtest case that is not behaving as Roku, the implementation is wrong, to be fixed later whenroXMLListis implemented.