Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Invite player function and integration test case for the function #101

Merged
merged 10 commits into from
Oct 13, 2024
Merged

feat: Add Invite player function and integration test case for the function #101

merged 10 commits into from
Oct 13, 2024

Conversation

CollinsC1O
Copy link
Contributor

@CollinsC1O CollinsC1O commented Oct 6, 2024 •
edited by princeibs
Loading

Add Invite player function and integration test case for the function

Closes #83

Details

  • Added an invite_player function to the game_action module.
  • Implemented invited_players array type in the game module where invited players are to be added
  • Implemented Integration test case for the Invite_payer function, in test_game module.

waiting on feedback on any required changes if/where necessary. Thanks

@CollinsC1O
Copy link
Contributor Author

Hello @princeibs @vibenedict kindly review #101

@princeibs princeibs self-requested a review October 9, 2024 06:29
princeibs
princeibs requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@princeibs princeibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing CI

@CollinsC1O
Copy link
Contributor Author

Ok I will do that

@princeibs princeibs merged commit b0e8da8 into sivicstudio:dev Oct 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princeibs princeibs princeibs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the "Invite player" function
2 participants
@CollinsC1O @princeibs