Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Support glossaries #5

Open
jobee opened this issue Feb 7, 2022 · 7 comments · May be fixed by #46
Open

FEATURE: Support glossaries #5

jobee opened this issue Feb 7, 2022 · 7 comments · May be fixed by #46

Comments

@jobee
Copy link

jobee commented Feb 7, 2022

First of all, thank you for this package! I love it.

I've seen Deepl added glossary support via the API. Some projects might benefit from that...
https://www.deepl.com/docs-api/managing-glossaries/

(I'll take care of it myself, as soon as a client requests it ;-))
@mficzel
Copy link
Member

mficzel commented Feb 11, 2022

We would accept a pr for that or do it once a client needs that. Before that this will have to wait.

@gradinarufelix
Copy link
Collaborator

Hi @jobee,

I came up with a lightweight solution in the meantime, see PR #10. You can now define terms to be ignored. Instead of implementing the whole glossaries API, I am currently wrapping those terms using preg_replace in a <ignore> tag. I tested it and it worked so far. Happy to hear from you if that solves your case.

@jobee
Copy link
Author

jobee commented Apr 21, 2022

@gradinarufelix I like that. Ignoring terms can be very useful in some projects.
However, I would leave this issue open as well.

@robert-heinig
Copy link

FYI: On of our customers sponsors the development of the glossary integration.
My goal is to integrate this feature officially into this package.

@gradinarufelix
Copy link
Collaborator

@robert-heinig any updates on this? 😄

@paavo
Copy link

paavo commented Mar 20, 2024

@robert-heinig any Update on the glossary integration?

@lorenzulrich
Copy link

@robert-heinig Same here, any update in the glossary integration?

@lorenzulrich lorenzulrich linked a pull request Jul 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft: FEATURE: Add glossary management lorenzulrich/Sitegeist.LostInTranslation
6 participants
@paavo @mficzel @lorenzulrich @gradinarufelix @jobee @robert-heinig