fix damage checks

sisby-folk · Aug 26, 2024 · 694eacb · 694eacb
1 parent e3c1f06
commit 694eacb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/folk/sisby/tinkerers_smithing/recipe/SacrificeUpgradeRecipe.java b/src/main/java/folk/sisby/tinkerers_smithing/recipe/SacrificeUpgradeRecipe.java
@@ -45,8 +45,9 @@ public static int resultDamage(Item resultItem, int additionUnits, int resultUni
  public ItemStack craft(Inventory inventory) {
  ItemStack output = super.craft(inventory);
  ItemStack addition = inventory.getStack(1);
- output.setDamage(resultDamage(output.getItem(), additionUnits, resultUnits, addition.getDamage(), addition.getMaxDamage()));
- if (output.getDamage() > output.getMaxDamage()) return ItemStack.EMPTY;
+ int damage = resultDamage(output.getItem(), additionUnits, resultUnits, addition.getDamage(), addition.getMaxDamage());
+ if (damage > output.getMaxDamage()) return ItemStack.EMPTY;
+ output.setDamage(damage);
  return output;
  }
 

diff --git a/src/main/java/folk/sisby/tinkerers_smithing/recipe/SmithingUpgradeRecipe.java b/src/main/java/folk/sisby/tinkerers_smithing/recipe/SmithingUpgradeRecipe.java
@@ -42,8 +42,9 @@ public static int resultDamage(Item resultItem, int additionCount, int usedCount
  public ItemStack craft(Inventory inventory) {
  ItemStack output = super.craft(inventory);
  int usedCount = Math.min(additionCount, inventory.getStack(1).getCount());
- output.setDamage(resultDamage(output.getItem(), additionCount, usedCount));
- if (output.getDamage() > output.getMaxDamage()) return ItemStack.EMPTY;
+ int damage = resultDamage(output.getItem(), additionCount, usedCount);
+ if (damage > output.getMaxDamage()) return ItemStack.EMPTY;
+ output.setDamage(damage);
  return output;
  }