[python] Remove a temp comment, and complete Python 3.12 checks #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
- Coverage 78.43% 71.77% -6.67%
==========================================
Files 136 101 -35
Lines 10695 6920 -3775
Branches 211 211
==========================================
- Hits 8389 4967 -3422
+ Misses 2204 1851 -353
Partials 102 102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bkmartinjr
approved these changes
Feb 13, 2024
This was referenced Feb 14, 2024
Merged
|
Abandoning with details on issue #1849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged #2135 -- it had green pre-merge CI (which is good!) but failed a post-merge check.
Issue #1849.