Skip to content

Commit

Permalink
Fix font color and background color icons is reversed
Browse files Browse the repository at this point in the history
  • Loading branch information
EchoEllet committed Nov 4, 2023
1 parent 2faeda8 commit 1b6859d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## [8.1.5]
- Background/Font Color toolbar button icons reversed.

## [8.1.4]
- Background/Font Color toolbar button tooltips reversed.

Expand Down
2 changes: 1 addition & 1 deletion lib/src/widgets/toolbar/buttons/color.dart
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class _QuillToolbarColorButtonState extends State<QuillToolbarColorButton> {
IconData get iconData {
return options.iconData ??
baseButtonExtraOptions.iconData ??
(widget.isBackground ? Icons.color_lens : Icons.format_color_fill);
(widget.isBackground ? Icons.format_color_fill : Icons.color_lens);

This comment has been minimized.

Copy link
@EchoEllet

EchoEllet Nov 4, 2023

Author Collaborator

@singerdmx
Do these new default icons for the background color and font color make more sense to you?? it does to me but it's a matter of preference

This comment has been minimized.

Copy link
@singerdmx

singerdmx Nov 4, 2023

Owner

LGTM

}

String get tooltip {
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flutter_quill
description: A rich text editor built for the modern Android, iOS, web and desktop platforms. It is the WYSIWYG editor and a Quill component for Flutter.
version: 8.1.4
version: 8.1.5
homepage: https://1o24bbs.com/c/bulletjournal/108
repository: https://github.com/singerdmx/flutter-quill

Expand Down

0 comments on commit 1b6859d

Please sign in to comment.