Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tdl 14624 crest master #88

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Tdl 14624 crest master #88

merged 6 commits into from
Nov 11, 2021

Commits on Nov 10, 2021

  1. Tdl 14803 check api access in discovery mode (#84) 

    * API call to the each stream in discovery mode done

* removed generated catalog file

* resolved pylint errors

* Resolved cyclic import pylint error

* Improved unittest case civerage

* Updated error message for 403 forbidden error

* Updated error handling

* resolved pylint error

* Removed empty catalog

* Removed unused catalog file.

* Removed unused state file

* Removed unused state file

* Removed unused file

* Updated error message and unittest case for 404 error

* Updated check access method

* Resolved pylint error

* recolved unused argument error

* resolved kwargs error

* Updated unittest cases

* Updated unittest cases

* Removed global variable

* Improved unittest case coverage

* updated 404 error

* resolved pylint error

* Updated typo error.

* Removed f strings

* Updated error handling

* resloved pylint error

* resolved unittest case error

* Added more comments and updated code

* resolved pylint error

* updated method name

* Added timeout error code

* Resolved pylint error

* added coverage report to artifact

* added pylint back

* Added comment

* resolved pylint errors

* Enhanced the code

* Reutilized args0

* Moved request_timeout parameter to common class

* Added comment

* Removed static time

* removed warning message

* resolved pylint error

* resolved the comments

Co-authored-by: namrata270998 <[email protected]>
    @prijendev @namrata270998
    prijendev and namrata270998 authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    6ea6e17 View commit details
    Browse the repository at this point in the history

  2. Tdl 15454 remove buffer from tickets (#85) 

    * removed the buffer systesm

* removed the unnecessary methods

* fixed pylint errors

* resolved pylint errors

* added comments in test file

* Added coverage report

* added comment

* added logger for printingcount of child streams

* updated unittest

Co-authored-by: namrata270998 <[email protected]>
    @prijendev @namrata270998
    prijendev and namrata270998 authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    bb6a146 View commit details
    Browse the repository at this point in the history

  3. Tdl 14799 correctly print logger (#86) 

    * TDL-14799 added an extra check to verify if the error has message in it or not

* TDL-14799-removed-the-extra-whitespaces

* TDL-14799 resolved the comments

* added new test cases and removed unwanted changes

* added a new line

* resolved the comment

Co-authored-by: savan-chovatiya <[email protected]>

* removed the trailing whitespace which failed the build

* added pytest in the setup.py

* added coverage report

* added comments to testcases

* added comment in the streams.py

Co-authored-by: namrata270998 <[email protected]>
Co-authored-by: namrata270998 <[email protected]>
Co-authored-by: savan-chovatiya <[email protected]>
    @prijendev @namrata270998 @savan-chovatiya
    4 people authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    25eeca3 View commit details
    Browse the repository at this point in the history

  4. Updated unittest case

    @prijendev
    prijendev committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    6cffdcb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'TDL-14624-crest-master' of https://github.com/singer-io… 

    …/tap-zendesk into TDL-14624-crest-master
    @prijendev
    prijendev committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    fa92a2d View commit details
    Browse the repository at this point in the history

  6. Tdl 15582 check best practices (#87) 

    * Initial commit for best practises

* Updated all_fields test case

* Removed commented code

* added coverage report

* removed f string all fields test case

* Updated test cases

* Updated test case

* Updated start_date for ticket_forms

* updated start_date
    @prijendev
    prijendev authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    da3b48f View commit details
    Browse the repository at this point in the history